8x48/KnowStreaming
1
0
Fork 0
mirror of https://github.com/didi/KnowStreaming.git synced 2026-01-07 14:44:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Optimize]Jmx相关日志优化 (#1082)

Browse Source 
1、统一Jmx客户端相关日志格式；
2、增加创建的Jmx-Connector时，所使用的信息；
3、优化日志级别；
This commit is contained in:
EricZeng
2023-07-06 15:39:51 +08:00
committed by GitHub
parent 470e471cad
commit 0a6e9b7633
3 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
km-common/src/main/java/com/xiaojukeji/know/streaming/km/common/jmx/JmxConnectorWrap.java
View File

@@ -46,7 +46,12 @@ public class JmxConnectorWrap {
private JmxAuthConfig jmxConfig; private JmxAuthConfig jmxConfig;
public JmxConnectorWrap(String clientLogIdent, Long brokerStartupTime, String jmxHost, Integer jmxPort, JmxAuthConfig jmxConfig) { public JmxConnectorWrap(String clientLogIdent, Long brokerStartupTime, String jmxHost, Integer jmxPort, JmxAuthConfig jmxConfig) {
this.clientLogIdent=clientLogIdent; LOGGER.info(
"method=JmxConnectorWrap||clientLogIdent={}||brokerStartupTime={}||jmxHost={}||jmxPort={}||jmxConfig={}||msg=start construct JmxWrap.",
clientLogIdent, brokerStartupTime, jmxHost, jmxPort, jmxConfig
);
this.clientLogIdent = clientLogIdent;
this.brokerStartupTime = brokerStartupTime; this.brokerStartupTime = brokerStartupTime;
this.jmxHost = jmxHost; this.jmxHost = jmxHost;
this.jmxPort = (jmxPort == null? JmxEnum.UNKNOWN.getPort() : jmxPort); this.jmxPort = (jmxPort == null? JmxEnum.UNKNOWN.getPort() : jmxPort);
@@ -160,6 +165,11 @@ public class JmxConnectorWrap {
if (jmxConnector != null) { if (jmxConnector != null) {
return true; return true;
} }
LOGGER.info(
"method=createJmxConnector||clientLogIdent={}||brokerStartupTime={}||jmxHost={}||jmxPort={}||jmxConfig={}||msg=start create jmx connector.",
clientLogIdent, brokerStartupTime, jmxHost, jmxPort, jmxConfig
);
String jmxUrl = String.format("service:jmx:rmi:///jndi/rmi://%s:%d/jmxrmi", jmxHost, jmxPort); String jmxUrl = String.format("service:jmx:rmi:///jndi/rmi://%s:%d/jmxrmi", jmxHost, jmxPort);
try { try {
Map<String, Object> environment = new HashMap<String, Object>(); Map<String, Object> environment = new HashMap<String, Object>();

11
km-persistence/src/main/java/com/xiaojukeji/know/streaming/km/persistence/connect/ConnectJMXClient.java
View File

@@ -78,16 +78,15 @@ public class ConnectJMXClient extends AbstractConnectClusterChangeHandler {
return jmxConnectorWrap; return jmxConnectorWrap;
} }
log.debug("method=createJmxConnectorWrap||connectClusterId={}||workerId={}||msg=create JmxConnectorWrap starting", connectCluster.getId(), workerId); log.info("method=createJmxConnectorWrap||connectClusterId={}||workerId={}||msg=create JmxConnectorWrap starting", connectCluster.getId(), workerId);
JmxConfig jmxConfig = ConvertUtil.str2ObjByJson(connectCluster.getJmxProperties(), JmxConfig.class); JmxConfig jmxConfig = ConvertUtil.str2ObjByJson(connectCluster.getJmxProperties(), JmxConfig.class);
if (jmxConfig == null) { if (jmxConfig == null) {
jmxConfig = new JmxConfig(); jmxConfig = new JmxConfig();
} }
jmxConnectorWrap = new JmxConnectorWrap( jmxConnectorWrap = new JmxConnectorWrap(
"connectClusterId: " + connectCluster.getId() + " workerId: " + workerId, String.format("clusterPhyId=%s,workerId=%s", connectCluster.getId(), workerId),
null, null,
connectWorker.getHost(), connectWorker.getHost(),
jmxConfig.getFinallyJmxPort(workerId, connectWorker.getJmxPort()), jmxConfig.getFinallyJmxPort(workerId, connectWorker.getJmxPort()),
@@ -97,12 +96,16 @@ public class ConnectJMXClient extends AbstractConnectClusterChangeHandler {
Map<String, JmxConnectorWrap> workerMap = JMX_MAP.getOrDefault(connectCluster.getId(), new ConcurrentHashMap<>()); Map<String, JmxConnectorWrap> workerMap = JMX_MAP.getOrDefault(connectCluster.getId(), new ConcurrentHashMap<>());
workerMap.put(workerId, jmxConnectorWrap); workerMap.put(workerId, jmxConnectorWrap);
JMX_MAP.put(connectCluster.getId(), workerMap); JMX_MAP.put(connectCluster.getId(), workerMap);
log.info("method=createJmxConnectorWrap||clusterPhyId={}||workerId={}||msg=create JmxConnectorWrap success", connectCluster.getId(), workerId);
return jmxConnectorWrap; return jmxConnectorWrap;
} catch (Exception e) { } catch (Exception e) {
log.debug("method=createJmxConnectorWrap||connectClusterId={}||workerId={}||msg=create JmxConnectorWrap failed||errMsg=exception||", connectCluster.getId(), workerId, e); log.error("method=createJmxConnectorWrap||connectClusterId={}||workerId={}||msg=create JmxConnectorWrap failed||errMsg=exception||", connectCluster.getId(), workerId, e);
} finally { } finally {
modifyClientMapLock.unlock(); modifyClientMapLock.unlock();
} }
return null; return null;
} }

4
km-persistence/src/main/java/com/xiaojukeji/know/streaming/km/persistence/kafka/KafkaJMXClient.java
View File

@@ -151,7 +151,7 @@ public class KafkaJMXClient extends AbstractClusterLoadedChangedHandler {
return jmxMap; return jmxMap;
} }
log.debug("method=createJmxConnectorWrap||clusterPhyId={}||brokerId={}||msg=create JmxConnectorWrap starting", clusterPhy.getId(), brokerId); log.info("method=createJmxConnectorWrap||clusterPhyId={}||brokerId={}||msg=create JmxConnectorWrap starting", clusterPhy.getId(), brokerId);
JmxConfig jmxConfig = ConvertUtil.str2ObjByJson(clusterPhy.getJmxProperties(), JmxConfig.class); JmxConfig jmxConfig = ConvertUtil.str2ObjByJson(clusterPhy.getJmxProperties(), JmxConfig.class);
if (jmxConfig == null) { if (jmxConfig == null) {
@@ -159,7 +159,7 @@ public class KafkaJMXClient extends AbstractClusterLoadedChangedHandler {
} }
JmxConnectorWrap jmxConnectorWrap = new JmxConnectorWrap( JmxConnectorWrap jmxConnectorWrap = new JmxConnectorWrap(
"clusterPhyId: " + clusterPhy.getId() + " brokerId: " + brokerId, String.format("clusterPhyId=%s,brokerId=%d", clusterPhy.getId(), brokerId),
broker.getStartTimestamp(), broker.getStartTimestamp(),
broker.getJmxHost(jmxConfig.getUseWhichEndpoint()), broker.getJmxHost(jmxConfig.getUseWhichEndpoint()),
jmxConfig.getFinallyJmxPort(String.valueOf(brokerId), broker.getJmxPort()), jmxConfig.getFinallyJmxPort(String.valueOf(brokerId), broker.getJmxPort()),