optimize result code

This commit is contained in:
zengqiao
2021-01-28 12:06:06 +08:00
parent 73e6afcbc6
commit 4c429ad604
6 changed files with 79 additions and 108 deletions

View File

@@ -1,7 +1,6 @@
package com.xiaojukeji.kafka.manager.service.service.impl;
import com.xiaojukeji.kafka.manager.common.bizenum.DBStatusEnum;
import com.xiaojukeji.kafka.manager.common.constant.Constant;
import com.xiaojukeji.kafka.manager.common.entity.Result;
import com.xiaojukeji.kafka.manager.common.entity.ResultStatus;
import com.xiaojukeji.kafka.manager.common.entity.ao.ClusterDetailDTO;
@@ -72,7 +71,7 @@ public class ClusterServiceImpl implements ClusterService {
return ResultStatus.PARAM_ILLEGAL;
}
if (!isZookeeperLegal(clusterDO.getZookeeper())) {
return ResultStatus.CONNECT_ZOOKEEPER_FAILED;
return ResultStatus.ZOOKEEPER_CONNECT_FAILED;
}
try {
if (clusterDao.insert(clusterDO) <= 0) {
@@ -102,7 +101,7 @@ public class ClusterServiceImpl implements ClusterService {
if (!originClusterDO.getZookeeper().equals(clusterDO.getZookeeper())) {
// 不允许修改zk地址
return ResultStatus.CHANGE_ZOOKEEPER_FORBIDEN;
return ResultStatus.CHANGE_ZOOKEEPER_FORBIDDEN;
}
clusterDO.setStatus(originClusterDO.getStatus());
return updateById(clusterDO);

View File

@@ -53,7 +53,7 @@ public class ZookeeperServiceImpl implements ZookeeperService {
}
ZkConfigImpl zkConfig = PhysicalClusterMetadataManager.getZKConfig(clusterId);
if (ValidateUtils.isNull(zkConfig)) {
return Result.buildFrom(ResultStatus.CONNECT_ZOOKEEPER_FAILED);
return Result.buildFrom(ResultStatus.ZOOKEEPER_CONNECT_FAILED);
}
try {
@@ -68,6 +68,6 @@ public class ZookeeperServiceImpl implements ZookeeperService {
} catch (Exception e) {
LOGGER.error("class=ZookeeperServiceImpl||method=getControllerPreferredCandidates||clusterId={}||errMsg={}", clusterId, e.getMessage());
}
return Result.buildFrom(ResultStatus.READ_ZOOKEEPER_FAILED);
return Result.buildFrom(ResultStatus.ZOOKEEPER_READ_FAILED);
}
}