optimize result code

This commit is contained in:
zengqiao
2021-01-28 12:06:06 +08:00
parent 73e6afcbc6
commit 4c429ad604
6 changed files with 79 additions and 108 deletions

View File

@@ -95,7 +95,7 @@ public class ApplyAuthorityOrder extends AbstractAuthorityOrder {
}
TopicDO topicDO = topicManagerService.getByTopicName(physicalClusterId, orderExtensionDTO.getTopicName());
if (ValidateUtils.isNull(topicDO)) {
return ResultStatus.TOPIC_NOT_EXIST;
return ResultStatus.TOPIC_BIZ_DATA_NOT_EXIST;
}
AppDO appDO = appService.getByAppId(topicDO.getAppId());
if (!appDO.getPrincipals().contains(userName)) {

View File

@@ -23,7 +23,7 @@ public class Local extends AbstractStorageService {
@Override
public Result<String> download(String fileName, String fileMd5) {
return Result.buildFrom(ResultStatus.DOWNLOAD_FILE_FAIL);
return Result.buildFrom(ResultStatus.STORAGE_DOWNLOAD_FILE_FAILED);
}
@Override

View File

@@ -52,7 +52,7 @@ public class KafkaFileServiceImpl implements KafkaFileService {
kafkaFileDTO.getUploadFile())
) {
kafkaFileDao.deleteById(kafkaFileDO.getId());
return ResultStatus.UPLOAD_FILE_FAIL;
return ResultStatus.STORAGE_UPLOAD_FILE_FAILED;
}
return ResultStatus.SUCCESS;
} catch (DuplicateKeyException e) {
@@ -113,7 +113,7 @@ public class KafkaFileServiceImpl implements KafkaFileService {
if (kafkaFileDao.updateById(kafkaFileDO) <= 0) {
return ResultStatus.MYSQL_ERROR;
}
return ResultStatus.UPLOAD_FILE_FAIL;
return ResultStatus.STORAGE_UPLOAD_FILE_FAILED;
} catch (Exception e) {
LOGGER.error("rollback modify kafka file failed, kafkaFileDTO:{}.", kafkaFileDTO, e);
}
@@ -169,7 +169,7 @@ public class KafkaFileServiceImpl implements KafkaFileService {
return Result.buildFrom(ResultStatus.RESOURCE_NOT_EXIST);
}
if (KafkaFileEnum.PACKAGE.getCode().equals(kafkaFileDO.getFileType())) {
return Result.buildFrom(ResultStatus.FILE_TYPE_NOT_SUPPORT);
return Result.buildFrom(ResultStatus.STORAGE_FILE_TYPE_NOT_SUPPORT);
}
return storageService.download(kafkaFileDO.getFileName(), kafkaFileDO.getFileMd5());