mirror of
https://github.com/didi/KnowStreaming.git
synced 2026-01-02 02:02:13 +08:00
optimize login failed message
This commit is contained in:
@@ -1,8 +1,6 @@
|
||||
package com.xiaojukeji.kafka.manager.web.api.versionone;
|
||||
|
||||
import com.xiaojukeji.kafka.manager.common.constant.Constant;
|
||||
import com.xiaojukeji.kafka.manager.common.entity.Result;
|
||||
import com.xiaojukeji.kafka.manager.common.entity.ResultStatus;
|
||||
import com.xiaojukeji.kafka.manager.common.entity.ao.account.Account;
|
||||
import com.xiaojukeji.kafka.manager.common.entity.dto.normal.LoginDTO;
|
||||
import com.xiaojukeji.kafka.manager.common.entity.vo.common.AccountVO;
|
||||
@@ -11,8 +9,6 @@ import com.xiaojukeji.kafka.manager.account.LoginService;
|
||||
import com.xiaojukeji.kafka.manager.common.constant.ApiPrefix;
|
||||
import io.swagger.annotations.Api;
|
||||
import io.swagger.annotations.ApiOperation;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import org.springframework.beans.factory.annotation.Autowired;
|
||||
import org.springframework.web.bind.annotation.*;
|
||||
|
||||
@@ -28,26 +24,22 @@ import javax.servlet.http.HttpServletResponse;
|
||||
@RestController
|
||||
@RequestMapping(ApiPrefix.API_V1_SSO_PREFIX)
|
||||
public class LoginController {
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(LoginController.class);
|
||||
|
||||
@Autowired
|
||||
private LoginService loginService;
|
||||
|
||||
@ApiOperation(value = "登陆", notes = "")
|
||||
@RequestMapping(value = "login", method = RequestMethod.POST)
|
||||
@ResponseBody
|
||||
public Result<AccountVO> login(HttpServletRequest request,
|
||||
HttpServletResponse response,
|
||||
@RequestBody LoginDTO dto){
|
||||
Account account = loginService.login(request, response, dto);
|
||||
if (ValidateUtils.isNull(account)) {
|
||||
return Result.buildFrom(ResultStatus.LOGIN_FAILED);
|
||||
public Result<AccountVO> login(HttpServletRequest request, HttpServletResponse response, @RequestBody LoginDTO dto){
|
||||
Result<Account> accountResult = loginService.login(request, response, dto);
|
||||
if (ValidateUtils.isNull(accountResult) || accountResult.failed()) {
|
||||
return new Result<>(accountResult.getCode(), accountResult.getMessage());
|
||||
}
|
||||
AccountVO vo = new AccountVO();
|
||||
vo.setUsername(account.getUsername());
|
||||
vo.setChineseName(account.getChineseName());
|
||||
vo.setDepartment(account.getDepartment());
|
||||
vo.setRole(account.getAccountRoleEnum().getRole());
|
||||
vo.setUsername(accountResult.getData().getUsername());
|
||||
vo.setChineseName(accountResult.getData().getChineseName());
|
||||
vo.setDepartment(accountResult.getData().getDepartment());
|
||||
vo.setRole(accountResult.getData().getAccountRoleEnum().getRole());
|
||||
return new Result<>(vo);
|
||||
}
|
||||
|
||||
@@ -58,28 +50,4 @@ public class LoginController {
|
||||
loginService.logout(request, response, true);
|
||||
return new Result();
|
||||
}
|
||||
|
||||
@Deprecated
|
||||
@ApiOperation(value = "登录检查", notes = "检查SSO返回的Code")
|
||||
@RequestMapping(value = "xiaojukeji/login-check", method = RequestMethod.POST)
|
||||
@ResponseBody
|
||||
public Result<AccountVO> checkCodeAndGetStaffInfo(HttpServletRequest request,
|
||||
HttpServletResponse response,
|
||||
@RequestBody LoginDTO dto) {
|
||||
Result<AccountVO> ra = login(request, response, dto);
|
||||
if (!Constant.SUCCESS.equals(ra.getCode())) {
|
||||
LOGGER.info("user login failed, req:{} result:{}.", dto, ra);
|
||||
} else {
|
||||
LOGGER.info("user login success, req:{} result:{}.", dto, ra);
|
||||
}
|
||||
return ra;
|
||||
}
|
||||
|
||||
@Deprecated
|
||||
@ApiOperation(value = "登出", notes = "")
|
||||
@RequestMapping(value = "xiaojukeji/logout", method = RequestMethod.DELETE)
|
||||
@ResponseBody
|
||||
public Result logout(HttpServletRequest request, HttpServletResponse response) {
|
||||
return logoff(request, response);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -35,7 +35,7 @@ public class RdAccountController {
|
||||
@RequestMapping(value = "accounts", method = RequestMethod.POST)
|
||||
@ResponseBody
|
||||
public Result addAccount(@RequestBody AccountDTO dto) {
|
||||
if (!dto.legal() || ValidateUtils.isNull(dto.getPassword())) {
|
||||
if (!dto.legal() || ValidateUtils.isBlank(dto.getPassword())) {
|
||||
return Result.buildFrom(ResultStatus.PARAM_ILLEGAL);
|
||||
}
|
||||
ResultStatus rs = accountService.createAccount(AccountConverter.convert2AccountDO(dto));
|
||||
|
||||
@@ -39,10 +39,10 @@ public class SwaggerConfig implements WebMvcConfigurer {
|
||||
|
||||
private ApiInfo apiInfo() {
|
||||
return new ApiInfoBuilder()
|
||||
.title("Kafka云平台-接口文档")
|
||||
.description("欢迎使用滴滴出行开源kafka-manager")
|
||||
.title("Logi-KafkaManager 接口文档")
|
||||
.description("欢迎使用滴滴Logi-KafkaManager")
|
||||
.contact("huangyiminghappy@163.com")
|
||||
.version("2.0")
|
||||
.version("2.2.0")
|
||||
.build();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user