[Optimize]优化Sonar扫描出的不规范代码

This commit is contained in:
zengqiao
2022-11-29 20:54:41 +08:00
parent 5127b600ec
commit c2fd0a8410
6 changed files with 12 additions and 18 deletions

View File

@@ -1,5 +1,7 @@
package com.xiaojukeji.know.streaming.km.core.service.broker.impl;
import com.didiglobal.logi.log.ILog;
import com.didiglobal.logi.log.LogFactory;
import com.xiaojukeji.know.streaming.km.common.bean.entity.broker.BrokerSpec;
import com.xiaojukeji.know.streaming.km.common.bean.po.config.PlatformClusterConfigPO;
import com.xiaojukeji.know.streaming.km.common.enums.config.ConfigGroupEnum;
@@ -15,11 +17,11 @@ import java.util.Map;
@Service
public class BrokerSpecServiceImpl implements BrokerSpecService {
private static final ILog LOGGER = LogFactory.getLog(BrokerSpecServiceImpl.class);
@Autowired
private PlatformClusterConfigService platformClusterConfigService;
@Override
public Map<Integer, BrokerSpec> getBrokerSpecMap(Long clusterPhyId) {
//获取规格信息
@@ -37,6 +39,4 @@ public class BrokerSpecServiceImpl implements BrokerSpecService {
}
return brokerSpecMap;
}
}

View File

@@ -9,7 +9,6 @@ import com.xiaojukeji.know.streaming.km.common.exception.NotExistException;
import com.xiaojukeji.know.streaming.km.common.exception.ParamErrorException;
import java.util.List;
import java.util.Set;
/**
* @author didi

View File

@@ -116,15 +116,16 @@ public class TopicServiceImpl implements TopicService {
@Override
public List<String> listRecentUpdateTopicNamesFromDB(Long clusterPhyId, Integer time) {
Date updateTime = DateUtils.getBeforeSeconds(new Date(), time);
LambdaQueryWrapper<TopicPO> lambdaQueryWrapper = new LambdaQueryWrapper<>();
lambdaQueryWrapper.eq(TopicPO::getClusterPhyId, clusterPhyId);
lambdaQueryWrapper.ge(TopicPO::getUpdateTime, updateTime);
List<TopicPO> topicPOS = topicDAO.selectList(lambdaQueryWrapper);
if (topicPOS.isEmpty()){
lambdaQueryWrapper.ge(TopicPO::getClusterPhyId, clusterPhyId);
lambdaQueryWrapper.ge(TopicPO::getUpdateTime, DateUtils.getBeforeSeconds(new Date(), time));
List<TopicPO> poList = topicDAO.selectList(lambdaQueryWrapper);
if (poList.isEmpty()){
return new ArrayList<>();
}
return topicPOS.stream().map(TopicPO::getTopicName).collect(Collectors.toList());
return poList.stream().map(elem -> elem.getTopicName()).collect(Collectors.toList());
}
@Override