8x48/KnowStreaming
1
0
Fork 0
mirror of https://github.com/didi/KnowStreaming.git synced 2025-12-24 03:42:07 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Optimize]优化Sonar代码扫描结果

Browse Source
This commit is contained in:
zengqiao
2022-12-14 14:07:30 +08:00
parent 4543a339b7
commit cd2c388e68
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
km-core/src/main/java/com/xiaojukeji/know/streaming/km/core/service/connect/connector/impl/ConnectorMetricServiceImpl.java
View File

@@ -392,13 +392,13 @@ public class ConnectorMetricServiceImpl extends BaseConnectorMetricService imple
} }
private List<Tuple<Long, String>> listTopNConnectorList(Long clusterPhyId, Integer topN) { private List<Tuple<Long, String>> listTopNConnectorList(Long clusterPhyId, Integer topN) {
List<ConnectorPO> connectorPOS = connectorService.listByKafkaClusterIdFromDB(clusterPhyId); List<ConnectorPO> poList = connectorService.listByKafkaClusterIdFromDB(clusterPhyId);
if (CollectionUtils.isEmpty(connectorPOS)) { if (CollectionUtils.isEmpty(poList)) {
return new ArrayList<>(); return new ArrayList<>();
} }
return connectorPOS.subList(0, Math.min(topN, connectorPOS.size())) return poList.subList(0, Math.min(topN, poList.size()))
.stream() .stream()
.map( c -> new Tuple<>(c.getId(), c.getConnectorName()) ) .map( c -> new Tuple<>(c.getId(), c.getConnectorName()) )
.collect(Collectors.toList()); .collect(Collectors.toList());

2
km-core/src/main/java/com/xiaojukeji/know/streaming/km/core/service/topic/impl/TopicMetricServiceImpl.java
View File

@@ -185,7 +185,7 @@ public class TopicMetricServiceImpl extends BaseMetricService implements TopicMe
Table<String/*metric*/, String/*topics*/, List<MetricPointVO>> retTable; Table<String/*metric*/, String/*topics*/, List<MetricPointVO>> retTable;
if(CollectionUtils.isEmpty(topics)) { if(CollectionUtils.isEmpty(topics)) {
//如果 es 中获取不到topN的topic就使用从数据库中获取的topics //如果 es 中获取不到topN的topic就使用从数据库中获取的topics
List<String> defaultTopics = listTopNTopics(clusterId, topN); List<String> defaultTopics = this.listTopNTopics(clusterId, topN);
retTable = topicMetricESDAO.listTopicMetricsByTopN(clusterId, defaultTopics, metrics, aggType, topN, startTime, endTime ); retTable = topicMetricESDAO.listTopicMetricsByTopN(clusterId, defaultTopics, metrics, aggType, topN, startTime, endTime );
}else { }else {
retTable = topicMetricESDAO.listTopicMetricsByTopics(clusterId, metrics, aggType, topics, startTime, endTime); retTable = topicMetricESDAO.listTopicMetricsByTopics(clusterId, metrics, aggType, topics, startTime, endTime);

2
km-rest/src/main/java/com/xiaojukeji/know/streaming/km/rest/api/v3/cluster/ClusterConnectsController.java
View File

@@ -119,7 +119,7 @@ public class ClusterConnectsController {
@PostMapping(value = "clusters/{clusterPhyId}/connectors-metrics") @PostMapping(value = "clusters/{clusterPhyId}/connectors-metrics")
@ResponseBody @ResponseBody
public Result<List<MetricMultiLinesVO>> getClusterPhyMetrics(@PathVariable Long clusterPhyId, public Result<List<MetricMultiLinesVO>> getClusterPhyMetrics(@PathVariable Long clusterPhyId,
@Validated @RequestBody MetricsConnectorsDTO dto) { @Validated @RequestBody MetricsConnectorsDTO dto) {
return connectorMetricService.listConnectClusterMetricsFromES(clusterPhyId, dto); return connectorMetricService.listConnectClusterMetricsFromES(clusterPhyId, dto);
} }