8x48/KnowStreaming
1
0
Fork 0
mirror of https://github.com/didi/KnowStreaming.git synced 2025-12-24 11:52:08 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

RegionService下的updateRegion的重载方法含义错误;应该是根据regionId更新region，参数应该是regionId，不是clusterId

Browse Source
This commit is contained in:
didi
2021-12-14 18:32:14 +08:00
parent 8086ef355b
commit 19b7f6ad8c
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kafka-manager-core/src/main/java/com/xiaojukeji/kafka/manager/service/service/RegionService.java
View File

@@ -54,12 +54,12 @@ public interface RegionService {
Map<Integer, RegionDO> convert2BrokerIdRegionMap(List<RegionDO> regionDOList);
/**
* 更新逻辑集群容量
* @param clusterId 集群id
* 根据RegionId更新Region
* @param regionId region的id
* @param newBrokerList 新的broker列表
* @return ResultStatus
*/
ResultStatus updateRegion(Long clusterId, String newBrokerList);
ResultStatus updateRegion(Long regionId, String newBrokerList);
/**
* 获取空闲的region的broker列表

6
kafka-manager-core/src/main/java/com/xiaojukeji/kafka/manager/service/service/impl/RegionServiceImpl.java
View File

@@ -134,11 +134,11 @@ public class RegionServiceImpl implements RegionService {
@Override
public ResultStatus updateRegion(Long clusterId, String newBrokerList) {
if (ValidateUtils.isNull(clusterId) || ValidateUtils.isExistBlank(newBrokerList)) {
public ResultStatus updateRegion(Long regionId, String newBrokerList) {
if (ValidateUtils.isNull(regionId) || ValidateUtils.isExistBlank(newBrokerList)) {
return ResultStatus.PARAM_ILLEGAL;
}
RegionDO regionDO = getById(clusterId);
RegionDO regionDO = getById(regionId);
if (ValidateUtils.isNull(regionDO)) {
return ResultStatus.CLUSTER_NOT_EXIST;
}